Thread (2 messages) 2 messages, 2 authors, 2018-10-23

Re: [PATCH net] qlcnic: fix a return in qlcnic_dcb_get_capability()

From: David Miller <davem@davemloft.net>
Date: 2018-10-23 10:56:00
Also in: kernel-janitors

From: Dan Carpenter <redacted>
Date: Fri, 19 Oct 2018 23:11:11 +0300
These functions are supposed to return one on failure and zero on
success.  Returning a zero here could cause uninitialized variable
bugs in several of the callers.  For example:

    drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority()
    error: uninitialized symbol 'caps'.

Fixes: 48365e485275 ("qlcnic: dcb: Add support for CEE Netlink interface.")
Signed-off-by: Dan Carpenter <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help