Re: [PATCH net-next 11/18] vxlan: Add netif_is_vxlan()

On Mon, 15 Oct 2018 13:30:41 -0700
Jakub Kicinski [off-list ref] wrote:

On Mon, 15 Oct 2018 23:27:41 +0300, Ido Schimmel wrote:

quoted

On Mon, Oct 15, 2018 at 01:16:42PM -0700, Stephen Hemminger wrote:  

quoted

On Mon, 15 Oct 2018 22:57:48 +0300
Ido Schimmel [off-list ref] wrote:
    

quoted

On Mon, Oct 15, 2018 at 11:57:56AM -0700, Jakub Kicinski wrote:    

quoted

On Sat, 13 Oct 2018 17:18:38 +0000, Ido Schimmel wrote:      

quoted

Add the ability to determine whether a netdev is a VxLAN netdev by
calling the above mentioned function that checks the netdev's private
flags.

This will allow modules to identify netdev events involving a VxLAN
netdev and act accordingly. For example, drivers capable of VxLAN
offload will need to configure the underlying device when a VxLAN netdev
is being enslaved to an offloaded bridge.

Signed-off-by: Ido Schimmel <redacted>
Reviewed-by: Petr Machata <redacted>      

Is this preferable over

!strcmp(netdev->rtnl_link_ops->kind, "vxlan")

which is what TC offloads do?      

Using a flag seemed like the more standard way.

That being said, we considered using net_device_ops instead, given we
are about to run out of available private flags, so I don't mind
adopting a technique already employed by another driver.

P.S. Had to Cc netdev again. I think your client somehow messed the Cc
list? I see Cc list in your reply, but with back slashes at the end of
two email addresses.    

Agree that using a global resource bit in flags is probably overkill.
If you can use kind that would be good example for other drivers as well.    

OK, will change.

Jakub, any objections if I implement netif_is_vxlan() using 'kind' and
convert nfp to use the helper? Having all these helpers in the same
location will increase the chances of others reusing them.  

Sounds very good :)

We could even do this for bridge, and other devices that are using private flags.