Thread (5 messages) flat view 5 messages, 3 authors, 2018-10-13

Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

From: David Miller <davem@davemloft.net>
Date: 2018-10-13 01:45:15

From: Eric Dumazet <redacted>
Date: Fri, 12 Oct 2018 08:19:20 -0700

On 10/12/2018 07:52 AM, David Howells wrote:
quoted
The udpv6_encap_enable() function is part of the ipv6 code, and if that is
configured as a loadable module and rxrpc is built in then a build failure
will occur because the conditional check is wrong:

  net/rxrpc/local_object.o: In function `rxrpc_lookup_local':
  local_object.c:(.text+0x2688): undefined reference to `udpv6_encap_enable'

Use the correct config symbol (CONFIG_AF_RXRPC_IPV6) in the conditional
check rather than CONFIG_IPV6 as that will do the right thing.

Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Arnd Bergmann <arnd@arndb.de>
Nit : Correct attribution would require a Reported-by: tag
Right.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help