[PATCH rdma-next 3/4] IB/mlx5: Verify that driver supports user flags
flat view
STALE2931d
From: Leon Romanovsky <leon@kernel.org>
Date: 2018-10-07 16:10:28
Also in:
linux-rdma
Subsystem:
infiniband subsystem, mellanox mlx5 ib driver, the rest · Maintainers:
Jason Gunthorpe, Leon Romanovsky, Linus Torvalds
Revision v1 of 2 in this series.
Revisions (2)
- v1 current
- v1
From: Yonatan Cohen <redacted> Flags sent down from user might not be supported by running driver. This might lead to unwanted bugs. To solve this, added macro to test for unsupported flags. Signed-off-by: Yonatan Cohen <redacted> Signed-off-by: Leon Romanovsky <redacted> --- drivers/infiniband/hw/mlx5/qp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index bae48bdf281c..17c4b6641933 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c@@ -1728,6 +1728,15 @@ static void configure_requester_scat_cqe(struct mlx5_ib_dev *dev, MLX5_SET(qpc, qpc, cs_req, MLX5_REQ_SCAT_DATA32_CQE); } +#define MLX5_QP_CREATE_FLAGS_NOT_SUPPORTED(flags) \ + ((flags) & ~( \ + MLX5_QP_FLAG_SIGNATURE | \ + MLX5_QP_FLAG_SCATTER_CQE | \ + MLX5_QP_FLAG_TUNNEL_OFFLOADS | \ + MLX5_QP_FLAG_BFREG_INDEX | \ + MLX5_QP_FLAG_TYPE_DCT | \ + MLX5_QP_FLAG_TYPE_DCI)) + static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd, struct ib_qp_init_attr *init_attr, struct ib_udata *udata, struct mlx5_ib_qp *qp)
@@ -1825,6 +1834,9 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd, return -EFAULT; } + if (MLX5_QP_CREATE_FLAGS_NOT_SUPPORTED(ucmd.flags)) + return -EINVAL; + err = get_qp_user_index(to_mucontext(pd->uobject->context), &ucmd, udata->inlen, &uidx); if (err)
--
2.14.4