Thread (2 messages) 2 messages, 2 authors, 2018-10-02

Re: [PATCH] Revert "openvswitch: Fix template leak in error cases."

From: Joe Stringer <hidden>
Date: 2018-10-02 05:26:19
Also in: netfilter-devel

On Fri, 28 Sep 2018 at 10:55, Flavio Leitner [off-list ref] wrote:
This reverts commit 90c7afc96cbbd77f44094b5b651261968e97de67.

When the commit was merged, the code used nf_ct_put() to free
the entry, but later on commit 76644232e612 ("openvswitch: Free
tmpl with tmpl_free.") replaced that with nf_ct_tmpl_free which
is a more appropriate. Now the original problem is removed.

Then 44d6e2f27328 ("net: Replace NF_CT_ASSERT() with WARN_ON().")
replaced a debug assert with a WARN_ON() which is trigged now.

Signed-off-by: Flavio Leitner <redacted>
---
Thanks for the cleanup.

Acked-by: Joe Stringer <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help