Thread (5 messages) flat view 5 messages, 4 authors, 2018-09-24

Re: [PATCH v2 net-next] ravb: remove tx buffer addr 4byte alilgnment restriction for R-Car Gen3

From: Sergei Shtylyov <hidden>
Date: 2018-09-20 14:18:47
Also in: linux-renesas-soc

On 9/20/2018 7:08 AM, David Miller wrote:
quoted
From: Kazuya Mizuguchi <redacted>

This patch sets from two descriptor to one descriptor because R-Car Gen3
does not have the 4 bytes alignment restriction of the transmission buffer.

Signed-off-by: Kazuya Mizuguchi <redacted>
Signed-off-by: Simon Horman <redacted>
---
v2 [Simon Horman]
* As per review by Sergi Shtylyov
   - Use reverse xmas tree for variable declarations
   - Use > rather than >= for conditions
   - Dropped unnecessary parentheses
   - Don't allocate memory for tx_align when it will not be used
   - But, kept NUM_TX_DESC_GEN[23] as I see some value in
     the self-documentation provided by these #defines

v1 [Kazuya Mizuguchi]
Applied, thanks.
    Mhm, I was just going to re-review the patch...

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help