Thread (2 messages) 2 messages, 2 authors, 2018-09-23

Re: [PATCH] net/mlx4: Use cpumask_available for eq->affinity_mask

From: Tariq Toukan <hidden>
Date: 2018-09-23 07:52:32
Also in: linux-rdma, lkml


On 21/09/2018 12:44 PM, Nathan Chancellor wrote:
quoted hunk ↗ jump to hunk
Clang warns that the address of a pointer will always evaluated as true
in a boolean context:

drivers/net/ethernet/mellanox/mlx4/eq.c:243:11: warning: address of
array 'eq->affinity_mask' will always evaluate to 'true'
[-Wpointer-bool-conversion]
         if (!eq->affinity_mask || cpumask_empty(eq->affinity_mask))
             ~~~~~^~~~~~~~~~~~~
1 warning generated.

Use cpumask_available, introduced in commit f7e30f01a9e2 ("cpumask: Add
helper cpumask_available()"), which does the proper checking and avoids
this warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/86
Signed-off-by: Nathan Chancellor <redacted>
---
  drivers/net/ethernet/mellanox/mlx4/eq.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
index 1f3372c1802e..2df92dbd38e1 100644
--- a/drivers/net/ethernet/mellanox/mlx4/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
@@ -240,7 +240,8 @@ static void mlx4_set_eq_affinity_hint(struct mlx4_priv *priv, int vec)
  	struct mlx4_dev *dev = &priv->dev;
  	struct mlx4_eq *eq = &priv->eq_table.eq[vec];
  
-	if (!eq->affinity_mask || cpumask_empty(eq->affinity_mask))
+	if (!cpumask_available(eq->affinity_mask) ||
+	    cpumask_empty(eq->affinity_mask))
  		return;
  
  	hint_err = irq_set_affinity_hint(eq->irq, eq->affinity_mask);
Reviewed-by: Tariq Toukan <redacted>
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help