Re: [PATCH] net: sched: Use FIELD_SIZEOF directly instead of reimplementing its function
From: zhong jiang <hidden>
Date: 2018-09-19 10:30:33
Also in:
lkml
On 2018/9/19 17:56, zhong jiang wrote:
FIELD_SIZEOF is defined as a macro to calculate the specified vaule. Therefore, We prefer to use the macro rather than calculating its vaule.
s/vaule/value. will resend. sorry. Thanks zhong jiang
quoted hunk ↗ jump to hunk
Signed-off-by: zhong jiang <redacted> --- net/sched/cls_flower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 4b8dd37..9aada2d 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c@@ -993,7 +993,7 @@ static int fl_init_mask_hashtable(struct fl_flow_mask *mask) } #define FL_KEY_MEMBER_OFFSET(member) offsetof(struct fl_flow_key, member) -#define FL_KEY_MEMBER_SIZE(member) (sizeof(((struct fl_flow_key *) 0)->member)) +#define FL_KEY_MEMBER_SIZE(member) FIELD_SIZEOF(struct fl_flow_key, member) #define FL_KEY_IS_MASKED(mask, member) \ memchr_inv(((char *)mask) + FL_KEY_MEMBER_OFFSET(member), \