Re: linux-next: Tree for Sep 18 (kernel/bpf/syscall)

On Tue, Sep 18, 2018 at 12:28 PM Willem de Bruijn
[off-list ref] wrote:

On Tue, Sep 18, 2018 at 11:44 AM Daniel Borkmann [off-list ref] wrote:

quoted

[ Cc Petar and Willem ]

On 09/18/2018 05:37 PM, Randy Dunlap wrote:

quoted

On 9/17/18 10:12 PM, Stephen Rothwell wrote:

quoted

Hi all,

Changes since 20180913:

on i386 or x86_64: (in 6 of 20 randconfigs)

kernel/bpf/syscall.o: In function `__x64_sys_bpf':
syscall.c:(.text+0x3278): undefined reference to `skb_flow_dissector_bpf_prog_attach'
syscall.c:(.text+0x3310): undefined reference to `skb_flow_dissector_bpf_prog_detach'
kernel/bpf/syscall.o:(.rodata+0x3f0): undefined reference to `flow_dissector_prog_ops'
kernel/bpf/verifier.o:(.rodata+0x250): undefined reference to `flow_dissector_verifier_ops'

Full randconfig file is attached.

Looks like we need a wrapper for these, config had:

# CONFIG_NET is not set

Thanks for forwarding the report.

For the functions, I think we can use a similar static inline stub as
used e.g., for bpf_map_offload_map_alloc.

The _ops references are from a macro that includes linux/bpf_types.h,
so indeed a CONFIG looks needed.

I need to look it over before I send out, but tentative patch:

Sent http://patchwork.ozlabs.org/patch/971280/