Re: [PATCH net-next 2/5] net: phy: mscc: Add EEE init sequence

On 09/14/18 01:33, Quentin Schulz wrote:

From: Raju Lakkaraju <redacted>

Microsemi PHYs (VSC 8530/31/40/41) need to update the Energy Efficient
Ethernet initialization sequence.
In order to avoid certain link state errors that could result in link
drops and packet loss, the physical coding sublayer (PCS) must be
updated with settings related to EEE in order to improve performance.

Signed-off-by: Raju Lakkaraju <redacted>
Signed-off-by: Quentin Schulz <redacted>
---

[snip]

+	vsc85xx_tr_write(phydev, 0x0f82, 0x0012b00a);

Can you just make this an array of register + value pair? That would be
less error prone in case you need to update that sequence in the future.

With that:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian