From: Qing Huang <redacted>
Date: Fri, 14 Sep 2018 11:33:40 -0700

On 9/14/2018 11:17 AM, Andrew Lunn wrote:

quoted

On Fri, Sep 14, 2018 at 10:15:48AM -0700, Qing Huang wrote:

quoted

The FW version is actually a very crucial piece of information and
only
printed once here
when the driver is loaded. People tend to get confused when switching
multiple FW files
back and forth without running separate utility tools, especially at
customer sites.
IMHO, this information is very useful and only takes up very little
log file
space. :-)

Why not use ethtool -i ?

$ sudo ethtool -i eth0
driver: r8169
version: 2.3LK-NAPI
firmware-version: rtl8168g-2_0.0.1 02/06/13

     Andrew

Sure. You can also use ibstat or ibv_devinfo tool if they are
installed. But it's not very
convenient in some cases.

E.g.
A customer upgrades FW on HCAs and encounters issues. During triage,
it's much easier
to study customer uploaded log files when remotely testing different
FW files.

Not a valid argument.  You can print the ethtool output from initramfs
if necessary for triage.

I still stand by the fact that ethtool is the only fully reliable way
to obtain this information, the kernel log is not.