Re: [PATCH v2,net-next 1/2] ip_gre: fix parsing gre header in ipgre_err
From: David Miller <davem@davemloft.net>
Date: 2018-09-13 17:58:44
Also in:
lkml
From: Haishuang Yan <redacted> Date: Wed, 12 Sep 2018 17:21:21 +0800
quoted hunk ↗ jump to hunk
@@ -86,7 +86,7 @@ int gre_parse_header(struct sk_buff *skb, struct tnl_ptk_info *tpi, options = (__be32 *)(greh + 1); if (greh->flags & GRE_CSUM) { - if (skb_checksum_simple_validate(skb)) { + if (csum_err && skb_checksum_simple_validate(skb)) { *csum_err = true; return -EINVAL; }
You want to ignore csum errors, but you do not want to elide the side effects of the skb_checksum_simple_validate() call which are to set skb->csum_valid and skb->csum. Therefore, the skb_checksum_simple_validate() call still needs to be performed. We just wont return -EINVAL in the NULL csum_err case.