Thread (3 messages) flat view 3 messages, 2 authors, 2018-09-08

Re: [PATCH] ethernet: hnae: add unlikely() to assert()

From: David Miller <davem@davemloft.net>
Date: 2018-09-07 21:47:05
Also in: lkml

From: Igor Stoppa <redacted>
Date: Fri,  7 Sep 2018 20:26:50 +0300
The assert() condition is likely to be true.
Worse than that is that drivers should not be definiting their own
private "assert()" macro.

I'd rather have that fixed instead.  We have tons of standard kernel
facilities that do what they are trying to do here, without overloading
the standard C namespace in this way.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help