Thread (4 messages) 4 messages, 3 authors, 2018-09-07

Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet

flat view

From: David Miller <davem@davemloft.net>
Date: 2018-09-07 17:35:18
Also in: lkml

From: Jakub Kicinski <redacted>
Date: Fri, 7 Sep 2018 18:36:36 +0200
On Fri,  7 Sep 2018 09:21:17 -0700, jun qian wrote:
quoted
As you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Signed-off-by: jun qian <redacted>
FWIW you should put spaces after the colons.  It's generally a good
practice to look at the prefix previous authors used for a given piece
of code with 

git log -- $file_path

This would be a better subject:

nfp: replace spin_lock_bh with spin_lock in tasklet callback
Yes, please fix your subject styling.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help