On Sun, Sep 02, 2018 at 02:01:41PM +0200, Janusz Krzysztofik wrote:
quoted hunk ↗ jump to hunk
@@ -461,7 +461,7 @@ static long linehandle_ioctl(struct file *filep, unsigned int cmd,
/* Clamp all values to [0,1] */
for (i = 0; i < lh->numdescs; i++)
- vals[i] = !!ghd.values[i];
+ __assign_bit(i, vals, !!ghd.values[i]);
The "!!" becomes unnecessary and can be removed, same for the code
comment above.
quoted hunk ↗ jump to hunk
/**
* gpiod_get_array_value() - read values from an array of GPIOs
- * @array_size: number of elements in the descriptor / value arrays
+ * @array_size: number of elements in the descriptor array / value bitmap
* @desc_array: array of GPIO descriptors whose values will be read
- * @value_array: array to store the read values
+ * @value_bitnap: bitmap to store the read values
Typo, s/bitnap/bitmap/
Otherwise LGTM.