Re: [Patch net-next v3] net_sched: change tcf_del_walker() to take idrinfo->lock
From: Cong Wang <hidden>
Date: 2018-09-29 11:01:22
On Fri, Sep 28, 2018 at 11:29 AM Cong Wang [off-list ref] wrote:
On Fri, Sep 28, 2018 at 11:11 AM Ido Schimmel [off-list ref] wrote:quoted
I don't think this will work given the reference count already dropped to 0, which is why the template deletion function was invoked. I didn't test the patch, but I don't see what would prevent the chain from being freed.Good catch! So I should just "move" tcf_chain_destroy() into cls_flower. A patch is being compiled now.
Just FYI, the crash is fixed, but another RCU warning pops up after my fix. So I am still debugging it, it is related to the kfree_rcu() in tcf_chain_destroy().