Re: [PATCH 11/15] octeontx2-af: Add Marvell OcteonTX2 CGX driver
flat view
From: Arnd Bergmann <arnd@arndb.de>
Date: 2018-09-28 14:37:49
On Fri, Sep 28, 2018 at 8:09 AM [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Sunil Goutham <sgoutham@marvell.com> This patch adds basic template for Marvell OcteonTX2's CGX ethernet interface driver. Just the probe. RVU AF driver will use APIs exported by this driver for various things like PF to physical interface mapping, loopback mode, interface stats etc. Hence marged both drivers into a single module. Signed-off-by: Sunil Goutham <sgoutham@marvell.com> --- drivers/net/ethernet/marvell/octeontx2/af/Makefile | 2 +- drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 100 +++++++++++++++++++++ drivers/net/ethernet/marvell/octeontx2/af/cgx.h | 22 +++++ drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 14 ++- 4 files changed, 136 insertions(+), 2 deletions(-) create mode 100644 drivers/net/ethernet/marvell/octeontx2/af/cgx.c create mode 100644 drivers/net/ethernet/marvell/octeontx2/af/cgx.hdiff --git a/drivers/net/ethernet/marvell/octeontx2/af/Makefile b/drivers/net/ethernet/marvell/octeontx2/af/Makefile index ac17cb9..8646421 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/Makefile +++ b/drivers/net/ethernet/marvell/octeontx2/af/Makefile@@ -7,4 +7,4 @@ obj-$(CONFIG_OCTEONTX2_MBOX) += octeontx2_mbox.o obj-$(CONFIG_OCTEONTX2_AF) += octeontx2_af.o octeontx2_mbox-y := mbox.o -octeontx2_af-y := rvu.o +octeontx2_af-y := cgx.o rvu.odiff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c new file mode 100644 index 0000000..cfd80d2 --- /dev/null +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
quoted hunk ↗ jump to hunk
+MODULE_AUTHOR("Marvell International Ltd."); +MODULE_DESCRIPTION(DRV_STRING); +MODULE_LICENSE("GPL v2"); +MODULE_DEVICE_TABLE(pci, cgx_id_table);
Since you now link both pci_driver instances in one module, I think
you need to remove the duplicate author/description/license tags.
Multiple device tables are fine I think.
Arnd