On Sep 27, 2018, at 11:25 AM, Michael Chan [off-list ref] wrote:

On Thu, Sep 27, 2018 at 9:32 AM Eric Dumazet [off-list ref] wrote:

quoted

Since we do no longer require NAPI drivers to provide
an ndo_poll_controller(), napi_schedule() has not been done
before poll_one_napi() invocation.

So testing NAPI_STATE_SCHED is likely to cause early returns.

While we are at it, remove outdated comment.

Note to future bisections : This change might surface prior
bugs in drivers. See commit 73f21c653f93 ("bnxt_en: Fix TX
timeout during netpoll.") for one occurrence.

Fixes: ac3d9dd034e5 ("netpoll: make ndo_poll_controller() optional")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Song Liu <redacted>
Cc: Michael Chan <michael.chan@broadcom.com>

Reviewed-and-tested-by: Michael Chan [off-list ref]

Reviewed-and-tested-by: Song Liu [off-list ref]