Hello Simon,

Thank you for your feedback!

Subject: Re: [PATCH 2/3][can-next] can: rcar_can: Add RZ/G2 support

On Thu, Aug 23, 2018 at 02:07:32PM +0100, Fabrizio Castro wrote:

quoted

RZ/G2 devices don't have clkp2, therefore this commit adds a
generic compatible string for them to allow for proper checking
during probe.

Signed-off-by: Fabrizio Castro <redacted>
Signed-off-by: Chris Paterson <redacted>

Are we sure these clocks are for all RZ/G2 SoCs?

Section 52.1.1 of the HW manual and Figure 52.1 state this.

Thanks,
Fab

If so


Reviewed-by: Simon Horman <redacted>

quoted

---

This patch applies on linux-can-next-for-4.19-20180727

 drivers/net/can/rcar/rcar_can.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/rcar/rcar_can.c
index fbd9284..397208e 100644
--- a/drivers/net/can/rcar/rcar_can.c
+++ b/drivers/net/can/rcar/rcar_can.c

@@ -27,6 +27,7 @@

 #define RCAR_SUPPORTED_CLOCKS(BIT(CLKR_CLKP1) | BIT(CLKR_CLKP2) | \
  BIT(CLKR_CLKEXT))
+#define RZG2_SUPPORTED_CLOCKS(BIT(CLKR_CLKP1) | BIT(CLKR_CLKEXT))

 /* Mailbox configuration:
  * mailbox 60 - 63 - Rx FIFO mailboxes

@@ -933,6 +934,10 @@ static const struct of_device_id rcar_can_of_table[] __maybe_unused = {
 .compatible = "renesas,rcar-gen3-can",
 .data = (void *)RCAR_SUPPORTED_CLOCKS,
 },
+{
+.compatible = "renesas,rzg-gen2-can",
+.data = (void *)RZG2_SUPPORTED_CLOCKS,
+},
 { }
 };
 MODULE_DEVICE_TABLE(of, rcar_can_of_table);
--

2.7.4

Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.