Thread (4 messages) 4 messages, 2 authors, 2018-08-30

Re: [PATCH net-next 0/2] ethtool: drop get_settings and set_settings ops

From: David Miller <davem@davemloft.net>
Date: 2018-08-30 02:46:31
Also in: linux-arm-kernel, lkml

From: Michal Kubecek <redacted>
Date: Tue, 28 Aug 2018 19:56:48 +0200 (CEST)
As Andrew Lunn pointed out in recent discussion, there is only one in tree
driver left which still defines deprecated callbacks get_settings() and
set_settings() in ethtool_ops. First patch converts this driver to
get_link_ksettings() and set_link_ksettings(). Second patch then removes
the deprecated callbacks from struct ethtool_ops and ethtool code which
falls back to them.

This doesn't break old versions of ethtool or any other userspace code
using ETHTOOL_{G,S}SET. We still implement both (old) ETHTOOL_{G,S}SET and
(new) ETHTOOL_{G,S}LINKSETTINGS ioctl commands but after this series both
will be implemented only using {g,s}et_link_ksettings(). The only affected
code would be out of tree NIC drivers which have not been converted yet.
Nice, thanks for following up on this.

Series applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help