Hi Jason,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.19-rc1 next-20180827]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jason-A-Donenfeld/WireGuard-Secure-Network-Tunnel/20180827-073051
config: arm-raumfeld_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   In file included from <command-line>:0:0:
   lib/zinc/chacha20/chacha20-arm-glue.h: In function 'chacha20_arch':

quoted

lib/zinc/chacha20/chacha20-arm-glue.h:36:3: error: implicit declaration of function 'chacha20_neon'; did you mean 'chacha20_arch'? [-Werror=implicit-function-declaration]

      chacha20_neon(dst, src, len, key, counter);
      ^~~~~~~~~~~~~
      chacha20_arch
   cc1: some warnings being treated as errors

vim +36 lib/zinc/chacha20/chacha20-arm-glue.h

959d9378 Jason A. Donenfeld 2018-08-24  26  
959d9378 Jason A. Donenfeld 2018-08-24  27  static inline bool chacha20_arch(u8 *dst, const u8 *src, const size_t len, const u32 key[8], const u32 counter[4], simd_context_t simd_context)
959d9378 Jason A. Donenfeld 2018-08-24  28  {
959d9378 Jason A. Donenfeld 2018-08-24  29  	if (simd_context != HAVE_FULL_SIMD
959d9378 Jason A. Donenfeld 2018-08-24  30  #if defined(ARM_USE_NEON)
959d9378 Jason A. Donenfeld 2018-08-24  31  		|| !chacha20_use_neon
959d9378 Jason A. Donenfeld 2018-08-24  32  #endif
959d9378 Jason A. Donenfeld 2018-08-24  33  	)
959d9378 Jason A. Donenfeld 2018-08-24  34  		chacha20_arm(dst, src, len, key, counter);
959d9378 Jason A. Donenfeld 2018-08-24  35  	else
959d9378 Jason A. Donenfeld 2018-08-24 @36  		chacha20_neon(dst, src, len, key, counter);
959d9378 Jason A. Donenfeld 2018-08-24  37  	return true;
959d9378 Jason A. Donenfeld 2018-08-24  38  }
959d9378 Jason A. Donenfeld 2018-08-24  39  

:::::: The code at line 36 was first introduced by commit
:::::: 959d93782f7ebf927cceeeb5ba86331211abfcd8 zinc: ChaCha20 ARM and ARM64 implementations

:::::: TO: Jason A. Donenfeld [off-list ref]
:::::: CC: 0day robot [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation