[PATCH 1/2] ethernet: declance: Use NULL to compare with pointer-typed value rather than 0
From: zhong jiang <hidden>
Date: 2018-08-18 06:42:00
Also in:
lkml
Subsystem:
dec lance network driver, networking drivers, the rest · Maintainers:
"Maciej W. Rozycki", Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. Signed-off-by: zhong jiang <redacted> --- drivers/net/ethernet/amd/declance.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
index 116997a..c636f02 100644
--- a/drivers/net/ethernet/amd/declance.c
+++ b/drivers/net/ethernet/amd/declance.c@@ -606,8 +606,7 @@ static int lance_rx(struct net_device *dev) } else { len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4; skb = netdev_alloc_skb(dev, len + 2); - - if (skb == 0) { + if (!skb) { dev->stats.rx_dropped++; *rds_ptr(rd, mblength, lp->type) = 0; *rds_ptr(rd, rmd1, lp->type) =
--
1.7.12.4