Re: [PATCH 14/28] net: split eth_platform_get_mac_address() into subroutines

2018-08-08 19:50 GMT+02:00 Andy Shevchenko [off-list ref]:

On Wed, Aug 8, 2018 at 6:31 PM, Bartosz Golaszewski [off-list ref] wrote:

quoted

From: Bartosz Golaszewski <redacted>

We want do add more sources from which to read the MAC address. In
order to avoid bloating this function too much, start by splitting it
into subroutines, each of which takes care of reading the MAC from
one source.

quoted

+static int mac_address_from_of(struct device *dev, u8 *mac_addr)
 {
        const unsigned char *addr;
+       struct device_node *np;

quoted

+       np = dev_is_pci(dev) ? pci_device_to_OF_node(to_pci_dev(dev))
+                            : dev->of_node;

I didn't get these manipulations.

What the scenario when pci_dev->dev.of_node != dev->of_node?

--
With Best Regards,
Andy Shevchenko

I'll add an additional patch that addresses it.

Bart