Re: [PATCH 24/33] net/mlx5e: Mark expected switch fall-throughs
From: Saeed Mahameed <hidden>
Date: 2018-08-08 22:26:52
Also in:
linux-rdma, lkml
On Tue, Aug 7, 2018 at 4:25 PM, Gustavo A. R. Silva [off-list ref] wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114808 ("Missing break in switch")
Addresses-Coverity-ID: 114802 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <redacted>Acked-by: Saeed Mahameed <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c index 1881468..ad6d471 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c@@ -91,9 +91,11 @@ bool mlx5e_xdp_handle(struct mlx5e_rq *rq, struct mlx5e_dma_info *di, return true; default: bpf_warn_invalid_xdp_action(act); + /* fall through */ case XDP_ABORTED: xdp_abort: trace_xdp_exception(rq->netdev, prog, act); + /* fall through */ case XDP_DROP: rq->stats->xdp_drop++; return true; --2.7.4