Thread (2 messages) flat view 2 messages, 2 authors, 2018-08-18

Re: [PATCH] fm10k_main.c: fix missing return value check of alloc_skb()

From: Andrew Lunn <andrew@lunn.ch>
Date: 2018-08-18 05:20:07

On Sat, Aug 18, 2018 at 10:00:58AM +0800, Jiecheng Wu wrote:
Function fm10k_init_module() defined in drivers/net/ethernet/intel/fm10k/fm10k_main.c calls alloc_workqueue() to allocate memory for struct workqueue_struct which is dereferenced immediately. As alloc_workqueue() may return NULL on failure, this code piece may cause NULL pointer dereference bug.
Hi Jiecheng

Please wrap your commit message to around 80 character wide.

You also need to add a Signed-off-by to your patch. Please see 

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

scripts/checkpatch.pl will help you get these things rights.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help