Re: [PATCH v3 net-next 3/9] net: stmmac: Add DMA related callbacks for XGMAC2

On 03-08-2018 19:58, Florian Fainelli wrote:

On 08/03/2018 08:50 AM, Jose Abreu wrote:

quoted

Add the DMA related callbacks for the new IP block XGMAC2.

Signed-off-by: Jose Abreu <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: Joao Pinto <redacted>
Cc: Giuseppe Cavallaro <redacted>
Cc: Alexandre Torgue <redacted>
---
+	value &= ~XGMAC_RD_OSR_LMT;
+	value |= (axi->axi_rd_osr_lmt << XGMAC_RD_OSR_LMT_SHIFT) &
+		XGMAC_RD_OSR_LMT;
+
+	for (i = 0; i < AXI_BLEN; i++) {
+		if (axi->axi_blen[i])
+			value &= ~XGMAC_UNDEF;

Should not you be you clearing all XGMAC_BLEN* values since you do a
logical or here? I am assuming this is not something that would likely
change from one open/close but still?

Yeah, this won't change between open/close but I will add the
mask anyway.

Thanks and Best Regards,
Jose Miguel Abreu