Re: [PATCH net-next] virtio_net: force_napi_tx module param.
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2018-08-02 01:22:34
On Wed, Aug 1, 2018 at 6:48 PM Michael S. Tsirkin [off-list ref] wrote:
On Wed, Aug 01, 2018 at 06:43:53PM -0400, Willem de Bruijn wrote:quoted
> > So e.g. we could set an affinity hint to a group of CPUs thatquoted
quoted
quoted
might transmit to this queue.We also want to set the xps mask for all cpus in the group to this queue. Is there a benefit over explicitly choosing one cpu from the set, btw?If only one CPU actually transmits on this queue then probably yes. And virtio doesn't know whether that's the case.Oh, yes, good example. To plumb that through, vp_set_vq_affinity would have to take a cpu mask like irq_set_affinity_hint, instead of a single value. Though I don't suggest doing that as part of the core virtnet_set_affinity changes.Why not? It seems a reasonable thing to do.
Well, at least let's split it into separate patches.