Thread (3 messages) 3 messages, 3 authors, 2018-08-01

Re: [PATCH] netlink: Fix spectre v1 gadget in netlink_create()

From: Josh Poimboeuf <hidden>
Date: 2018-07-31 21:23:58
Also in: lkml

On Tue, Jul 31, 2018 at 09:13:16PM +0000, Jeremy Cline wrote:
'protocol' is a user-controlled value, so sanitize it after the bounds
check to avoid using it for speculative out-of-bounds access to arrays
indexed by it.

This addresses the following accesses detected with the help of smatch:

* net/netlink/af_netlink.c:654 __netlink_create() warn: potential
  spectre issue 'nlk_cb_mutex_keys' [w]

* net/netlink/af_netlink.c:654 __netlink_create() warn: potential
  spectre issue 'nlk_cb_mutex_key_strings' [w]

* net/netlink/af_netlink.c:685 netlink_create() warn: potential spectre
  issue 'nl_table' [w] (local cap)

Cc: Josh Poimboeuf <redacted>
Signed-off-by: Jeremy Cline <redacted>
Reviewed-by: Josh Poimboeuf <redacted>

-- 
Josh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help