Re: [PATCH v1 3/3] net: WireGuard secure network tunnel

From
Stephen Hemminger <stephen@networkplumber.org>
Date
2018-07-31 20:27:10
Also in
lkml
Reply to
Jason A. Donenfeld, 2018-07-31
On Tue, 31 Jul 2018 21:11:02 +0200
"Jason A. Donenfeld" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+#define push(stack, p, len) ({ \
+	if (rcu_access_pointer(p)) { \
+		BUG_ON(len >= 128); \
+		stack[len++] = rcu_dereference_protected(p, lockdep_is_held(lock)); \
+	} \
+	true; \
+})
+static void free_root_node(struct allowedips_node __rcu *top, struct mutex *lock)
+{
+	struct allowedips_node *stack[128], *node;
+	unsigned int len;
+
+	for (len = 0, push(stack, top, len); len > 0 && (node = stack[--len]) && push(stack, node->bit[0], len) && push(stack, node->bit[1], len);)
+		call_rcu_bh(&node->rcu, node_free_rcu);
+}
This looks like you are doing traversal to free a tree.  The stack is there so that you do the rcu callbacks
in the proper order. Won't this create an lot of RCU work at once?
Thread (21 messages) 21 messages, 8 authors, last reply 2018-08-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help