Re: [PATCH 3/4] dt-bindings: net: phy: mscc: vsc8531: fix missing "/bits/ 8" in example
From: Andrew Lunn <andrew@lunn.ch>
Date: 2018-07-30 13:58:21
Also in:
linux-devicetree, lkml
On Mon, Jul 30, 2018 at 03:02:35PM +0200, Quentin Schulz wrote:
The "vsc8531,led-N-mode" property is read as a u8 in the driver and there aren't a lot of modes anyway. Without the "/bits/ 8" in front of the value of the property, the value is stored as an u32 resulting in of_read_property_u8 to always return 0.
Hi Quentin on big endian systems. I'm expect this worked on little endian ARM. I think the development work was done on a hacked RPi, if i remember correctly.
quoted hunk ↗ jump to hunk
Fix the example so that people using the property can actually use it. Signed-off-by: Quentin Schulz <redacted> --- Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt index 664d9d0543fc..4c7d1d384df0 100644 --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt@@ -63,6 +63,6 @@ Example: compatible = "ethernet-phy-id0007.0570"; vsc8531,vddmac = <3300>; vsc8531,edge-slowdown = <7>; - vsc8531,led-0-mode = <LINK_1000_ACTIVITY>; - vsc8531,led-1-mode = <LINK_100_ACTIVITY>; + vsc8531,led-0-mode = /bits/ 8 <LINK_1000_ACTIVITY>; + vsc8531,led-1-mode = /bits/ 8 <LINK_100_ACTIVITY>;
I don't know the device tree language well enough... Would this work? vsc8531,led-1-mode = < /bits/ 8 LINK_100_ACTIVITY>; If so, you can make it part of the #define. Andrew