Thread (11 messages) 11 messages, 5 authors, 2018-07-27

Re: [PATCH v1 0/4] PCI: Remove unnecessary includes of <linux/pci-aspm.h>

From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2018-07-25 21:00:04
Also in: intel-wired-lan, linux-pci, linux-wireless, lkml

On Wed, Jul 25, 2018 at 01:33:23PM -0700, Sinan Kaya wrote:
On 7/25/2018 12:52 PM, Bjorn Helgaas wrote:
quoted
emove includes of <linux/pci-aspm.h> from files that don't need
it.  I'll apply all these via the PCI tree unless there's objection.

---

Bjorn Helgaas (4):
       igb: Remove unnecessary include of <linux/pci-aspm.h>
       ath9k: Remove unnecessary include of <linux/pci-aspm.h>
       iwlwifi: Remove unnecessary include of <linux/pci-aspm.h>
       PCI: Remove unnecessary include of <linux/pci-aspm.h>
Thanks.

Reviewed-by: Sinan Kaya <okaya@kernel.org>

Is it possible to kill that file altogether? I haven't looked who is
using outside of pci directory.
Thanks for taking a look!

It's possible we could remove it altogether; there's very little in
it, and in most cases the only reason drivers include it is to disable
certain ASPM link states to work around hardware defects.  It might
make sense to just move that interface into <linux/pci.h>.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help