Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings
From: Kalle Valo <hidden>
Date: 2018-07-25 08:40:39
Also in:
linux-wireless, lkml
Possibly related (same subject, not in this thread)
- 2018-07-25 · Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings · H. Nikolaus Schaller <hidden>
- 2018-07-25 · Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings · Kalle Valo <hidden>
- 2018-07-25 · [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings · H. Nikolaus Schaller <hidden>
"H. Nikolaus Schaller" [off-list ref] writes:
quoted
Am 25.07.2018 um 08:40 schrieb Kalle Valo [off-list ref]: "H. Nikolaus Schaller" [off-list ref] writes:quoted
wl1271_warning() already appends a \n to the format, so adding one to the warning string gives empty lines in the log. Signed-off-by: H. Nikolaus Schaller <redacted>"drivers: net:" in the title is unnecessary, but I can remove that.Ok, thanks! I wasn't aware of the precise subsystem tagging style here.
Yeah, subsystems can do it a bit differently. But you can easily check with git log the preferred style: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject -- Kalle Valo