Re: [PATCH v6 18/18] crypto: Remove AHASH_REQUEST_ON_STACK
From: Kees Cook <hidden>
Date: 2018-07-24 17:53:35
Also in:
dm-devel, linux-block, linux-crypto, linux-pm, linux-wireless, lkml
On Tue, Jul 24, 2018 at 10:31 AM, Joe Perches [off-list ref] wrote:
quoted hunk ↗ jump to hunk
On Tue, 2018-07-24 at 09:49 -0700, Kees Cook wrote:quoted
All users of AHASH_REQUEST_ON_STACK have been removed from the kernel, so drop it entirely so no VLAs get reintroduced by future users.checkpatch has a test for that. It could now be removed as well. ---diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 34e4683de7a3..a3517334d661 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl@@ -796,7 +796,7 @@ our $declaration_macros = qr{(?x: (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(| (?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(| (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(| - (?:SKCIPHER_REQUEST|SHASH_DESC|AHASH_REQUEST)_ON_STACK\s*\( + (?:SKCIPHER_REQUEST|SHASH_DESC)_ON_STACK\s*\( )};
Ah! Cool. I've added this now. -Kees -- Kees Cook Pixel Security