Re: [PATCH 1/5] net: visually shrink eth_platform_get_mac_address()
From: David Miller <davem@davemloft.net>
Date: 2018-07-18 23:11:02
Also in:
linux-arm-kernel, linux-omap, lkml
From: Bartosz Golaszewski <redacted> Date: Wed, 18 Jul 2018 18:10:31 +0200
quoted hunk ↗ jump to hunk
@@ -527,15 +527,10 @@ unsigned char * __weak arch_get_platform_mac_address(void) int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr) { - const unsigned char *addr; - struct device_node *dp; + struct device_node *dp = dev_is_pci(dev) ? + pci_device_to_OF_node(to_pci_dev(dev)) : dev->of_node; + const unsigned char *addr = NULL; - if (dev_is_pci(dev)) - dp = pci_device_to_OF_node(to_pci_dev(dev)); - else - dp = dev->of_node; -
Reverse christmas tree is why the assignments are in the body of the function instead of the declaration area. Please don't do this, thanks.