Thread (7 messages) flat view 7 messages, 3 authors, 2018-07-11

Re: [net-next,v3] tcp: Improve setsockopt() TCP_USER_TIMEOUT accuracy

From: Eric Dumazet <hidden>
Date: 2018-07-10 12:48:30
Also in: lkml


On 07/10/2018 05:38 AM, Eric Dumazet wrote:
Note that if we always do jiffies_to_msecs(icsk->icsk_user_timeout) in TCP,
we also could change the convention and store msecs in this field instead of jiffies.

That would eliminate the msecs_to_jiffies() and jiffies_to_msecs() dance.

(That would be done in a patch of its own, of course)
tcp_keepalive_timer() does use icsk->icsk_user_timeout directly in jiffies unit,
but considering keeapalive timers are rarely used, this point would have to
do the msecs_to_jiffies() conversion.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help