Thread (6 messages) 6 messages, 2 authors, 2018-08-01

Re: [net-next v1] net/ipv6: allow any source address for sendmsg pktinfo with ip_nonlocal_bind

From: David Miller <davem@davemloft.net>
Date: 2018-07-30 17:44:24

From: Vincent Bernat <redacted>
Date: Mon, 30 Jul 2018 08:08:12 +0200
 ❦ 29 juillet 2018 12:28 -0700, David Miller [off-list ref] :
quoted
quoted
When freebind feature is set of an IPv6 socket, any source address can
be used when sending UDP datagrams using IPv6 PKTINFO ancillary
message. Global non-local bind feature was added in commit
35a256fee52c ("ipv6: Nonlocal bind") for IPv6. This commit also allows
IPv6 source address spoofing when non-local bind feature is enabled.

Signed-off-by: Vincent Bernat <redacted>
This definitely seems to make sense.  And is consistent with the other
tests involving freebind and transparent.

This test involving ip_nonlocal_bind, freeebind, and transparent happens
in several locations.  Perhaps we should add a helper function for
this?
Yes, I can do that. Should I also include one for SCTP?
If the helper for SCTP needs to be different and thus will only be
used in one place, probably not.  The whole idea is to remove
duplicated code, and prevent someone in the future from forgetting
to test all three values in these situations.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help