Re: [patch net-next] net: sched: don't dump chains only held by actions
From: Cong Wang <hidden>
Date: 2018-07-28 19:04:19
From: Cong Wang <hidden>
Date: 2018-07-28 19:04:19
On Sat, Jul 28, 2018 at 10:20 AM Cong Wang [off-list ref] wrote:
On Fri, Jul 27, 2018 at 12:47 AM Jiri Pirko [off-list ref] wrote:quoted
From: Jiri Pirko <redacted> In case a chain is empty and not explicitly created by a user, such chain should not exist. The only exception is if there is an action "goto chain" pointing to it. In that case, don't show the chain in the dump. Track the chain references held by actions and use them to find out if a chain should or should not be shown in chain dump. Signed-off-by: Jiri Pirko <redacted>Looks reasonable to me. Acked-by: Cong Wang <redacted>
Hold on... If you increase the refcnt for a zombie chain on NEWCHAIN path, then it would become a non-zombie, this makes sense. However, if the action_refcnt gets increased again when another action uses it, it become a zombie again because refcnt==action_refcnt??