Re: [PATCH][net-next][v2] net: convert gro_count to bitmask
From: David Miller <davem@davemloft.net>
Date: 2018-07-17 00:32:24
Subsystem:
networking [general], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
From: Eric Dumazet <redacted> Date: Mon, 16 Jul 2018 16:40:52 -0700
quoted hunk ↗ jump to hunk
I guess we could either use BITS_PER_LONG or :diff --git a/net/core/dev.c b/net/core/dev.c index c883b17ee0fe2c8a7ca2f2867560ba74004790a7..4f8b92d81d107fc9acd2499297435cbd9e9b5c67 100644 --- a/net/core/dev.c +++ b/net/core/dev.c@@ -9282,7 +9282,7 @@ static struct hlist_head * __net_init netdev_create_hash(void)
Commited thusly:
====================
[PATCH] net: Fix GRO_HASH_BUCKETS assertion.
FIELD_SIZEOF() is in bytes, but we want bits.
Fixes: d9f37d01e294 ("net: convert gro_count to bitmask")
Suggested-by: Eric Dumazet <redacted>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index c883b17ee0fe..4f8b92d81d10 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c@@ -9282,7 +9282,7 @@ static struct hlist_head * __net_init netdev_create_hash(void) static int __net_init netdev_init(struct net *net) { BUILD_BUG_ON(GRO_HASH_BUCKETS > - FIELD_SIZEOF(struct napi_struct, gro_bitmask)); + 8 * FIELD_SIZEOF(struct napi_struct, gro_bitmask)); if (net != &init_net) INIT_LIST_HEAD(&net->dev_base_head);
--
2.13.6