Re: [PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS

On 07/05/2018 03:20 AM, David Miller wrote:

From: Li RongQing <redacted>
Date: Thu,  5 Jul 2018 14:34:32 +0800

quoted

After commit 07d78363dcff ("net: Convert NAPI gro list into a small hash
table.")' there is 8 hash buckets, which allows more flows to be held for
merging.  but MAX_GRO_SKBS, the total held skb for merging, is 8 skb still,
limit the hash table performance.

keep MAX_GRO_SKBS as 8 skb, but limit each hash list length to 8 skb, not
the total 8 skb

Signed-off-by: Li RongQing <redacted>

Applied, thanks.

Maybe gro_count should be replaced by a bitmask, so that we can speed up
napi_gro_flush(), since it now has to use 3 cache lines (gro_hash[] size is 192 bytes)