Thread (6 messages) 6 messages, 4 authors, 2018-06-26

Re: [PATCH] NFC: llcp: fix nfc_llcp_send_ui_frame() lockup

From: Sergey Senozhatsky <hidden>
Date: 2018-06-26 05:12:29
Also in: linux-wireless, lkml

On (06/26/18 07:07), Dmitry Vyukov wrote:
[..]
quoted
 #include <net/nfc/nfc.h>
@@ -755,7 +756,8 @@ int nfc_llcp_send_ui_frame(struct nfc_llcp_sock *sock, u8 ssap, u8 dsap,
                pdu = nfc_alloc_send_skb(sock->dev, &sock->sk, MSG_DONTWAIT,
                                         frag_len + LLCP_HEADER_SIZE, &err);
                if (pdu == NULL) {
-                       pr_err("Could not allocate PDU\n");
+                       pr_err_ratelimited("Could not allocate PDU\n");
+                       cond_resched();
                        continue;
                }

But this thread is still in an infinite (unkillable?) loop? If yes, we
are waiting for the next syzbot report ;)
The loop is still infinite, correct, but we have a preemption point now.
Sure, net people can come with a much better solution, I'll be happy to
scratch my patch.

	-ss
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help