Re: [PATCH v4 2/3] bitfield: add u8 helpers
From: Andy Shevchenko <hidden>
Date: 2018-06-18 20:42:27
Also in:
lkml
On Mon, Jun 18, 2018 at 11:37 PM, Johannes Berg [off-list ref] wrote:
There's no reason why we shouldn't pack/unpack bits into/from u8 values/registers/etc., so add u8 helpers. Use the ____MAKE_OP() macro directly to avoid having nonsense le8_encode_bits() and similar functions.
Reviewed-by: Andy Shevchenko <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Johannes Berg <johannes@sipsolutions.net> --- include/linux/bitfield.h | 1 + 1 file changed, 1 insertion(+)diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h index 147a7bb341dd..65a6981eef7b 100644 --- a/include/linux/bitfield.h +++ b/include/linux/bitfield.h@@ -143,6 +143,7 @@ static __always_inline base type##_get_bits(__##type v, base field) \ ____MAKE_OP(le##size,u##size,cpu_to_le##size,le##size##_to_cpu) \ ____MAKE_OP(be##size,u##size,cpu_to_be##size,be##size##_to_cpu) \ ____MAKE_OP(u##size,u##size,,) +____MAKE_OP(u8,u8,,) __MAKE_OP(16) __MAKE_OP(32) __MAKE_OP(64) --2.14.4
-- With Best Regards, Andy Shevchenko