Re: [PATCH] net: cxgb3: add error handling for sysfs_create_group
From: David Miller <davem@davemloft.net>
Date: 2018-06-15 02:00:23
Also in:
lkml
From: Zhouyang Jia <redacted> Date: Thu, 14 Jun 2018 21:56:11 +0800
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index 2edfdbd..73d6aa9 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c@@ -3362,6 +3362,10 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) err = sysfs_create_group(&adapter->port[0]->dev.kobj, &cxgb3_attr_group); + if (err) { + dev_err(&pdev->dev, "cannot create sysfs group\n"); + goto out_free_dev; + }
You have to do more than this to cleanup. For example, you have to change the LED state back, as it has just been set to indicate that the interface is operational.