Thread (9 messages) 9 messages, 4 authors, 2018-06-15

Re: [PULL] vhost: cleanups and fixes

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2018-06-11 18:44:22
Also in: kvm, lkml, virtualization

On Mon, Jun 11, 2018 at 11:32 AM Linus Torvalds
[off-list ref] wrote:
So now we apparently do a GFP_KERNEL allocation insider the mm zone
lock, which is broken on just _so_ many levels.
Oh, I see the comment about how it doesn't actually do an allocation
at all because it's a single-entry.

Still too damn ugly to live, and much too fragile. No way in hell do
we even _hint_ at a GFP_KERNEL when we're inside a context that can't
do any memory allocation at all.

Plus I'm not convinced it's a "no allocation" path even despite that
comment, because it also does a "dma_map_page()" etc, which can cause
allocations to do the dma mapping thing afaik. No?

Maybe there's some reason why that doesn't happen either, but
basically this whole callchain looks *way* to complicated to be used
under a core VM spinlock.

                Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help