Thread (7 messages) flat view 7 messages, 3 authors, 2018-06-11

Re: [PATCH net] vhost_net: remove VHOST_NET_F_VIRTIO_NET_HDR support

From: David Miller <davem@davemloft.net>
Date: 2018-06-10 19:27:56
Also in: kvm, lkml, virtualization

From: Jason Wang <redacted>
Date: Fri,  8 Jun 2018 11:50:42 +0800
This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if
a userpsace want to enable VRITIO_F_ANY_LAYOUT,
VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will
break networking. Fixing this by safely removing
VHOST_NET_F_VIRTIO_NET_HDR support. There should be very few or even
no userspace can use this. Further cleanups could be done for
-net-next for safety.

In the future, we need a vhost dedicated feature set/get ioctl()
instead of reusing virtio ones.

Fixes: 4e9fa50c6ccbe ("vhost: move features to core")
Signed-off-by: Jason Wang <redacted>
I don't see this discussion as resolved yet so I'll mark this
as Deferred in patchwork.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help