Thread (10 messages) flat view 10 messages, 2 authors, 2018-06-07

Re: [PATCH 1/3] net: phy: Check phy_driver ready before accessing

From: Andrew Lunn <andrew@lunn.ch>
Date: 2018-06-07 18:12:43
Also in: lkml

Agreed. Another thing that looks suspicious to me is the driver
overrides the private data of the device it's attaching too, in the
`priv->phy_dev->priv = priv` bit. Seems like that could cause all
sorts of driver corruption problems.
Ah, yes. That is very broken. Many PHYs will just explode sometime
later, since they use phdev->priv.
But fixing that is going to require more drastic changes to how this
driver works. So it'd be worth applying this patch in the mean time.
Patches welcome.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help