Re: [net-next PATCH v5 3/7] net: sock: Change tx_queue_mapping in sock_common to unsigned short

On 6/29/2018 6:05 AM, David Miller wrote:

From: Amritha Nambiar <redacted>
Date: Wed, 27 Jun 2018 15:31:28 -0700

quoted

@@ -1681,17 +1681,25 @@ static inline int sk_receive_skb(struct sock *sk, struct sk_buff *skb,
 
 static inline void sk_tx_queue_set(struct sock *sk, int tx_queue)
 {
+	/* sk_tx_queue_mapping accept only upto a 16-bit value */
+	if (WARN_ON_ONCE((unsigned short)tx_queue > USHRT_MAX))
+		return;
 	sk->sk_tx_queue_mapping = tx_queue;
 }
 
+#define NO_QUEUE_MAPPING	USHRT_MAX

I think you need to check ">= USHRT_MAX" since USHRT_MAX is how you
indicate no queue.

Agree, I'll fix this.