Re: [PATCH bpf 4/4] xsk: fix potential race in SKB TX completion code

On 06/27/2018 05:55 PM, Eric Dumazet wrote:

On 06/27/2018 07:02 AM, Magnus Karlsson wrote:

quoted

There was a potential race in the TX completion code for
the SKB case when the TX napi thread and the error path
of the sendmsg code could both call the SKB destructor
at the same time. Fixed by introducing a spin_lock in the
destructor.

Wow, what is the impact on performance ?

Please describe a bit more what is the problem.

Agree, this should at min be better clarified in the commit log.

Thanks,
Daniel