Thread (24 messages) read the whole thread 24 messages, 3 authors, 2018-06-27

Re: [PATCH mlx5-next 05/12] net/mlx5: Rate limit errors in command interface

From: Leon Romanovsky <hidden>
Date: 2018-06-27 05:48:20
Also in: linux-rdma

On Sun, Jun 24, 2018 at 11:23:46AM +0300, Leon Romanovsky wrote:
From: Leon Romanovsky <redacted>

Any error status returned by FW will trigger similar
to the following error message in the dmesg.

[   55.884355] mlx5_core 0000:00:04.0: mlx5_cmd_check:712:(pid 555):
ALLOC_UAR(0x802) op_mod(0x0) failed, status limits exceeded(0x8),
syndrome (0x0)

Those prints are extremely valuable to diagnose issues with running
system and it is important to keep them. However, not-so-careful user
can trigger endless number of such prints by depleting HW resources
and will spam dmesg.

Rate limiting of such messages solves this issue.

Signed-off-by: Leon Romanovsky <redacted>
---
 drivers/net/ethernet/mellanox/mlx5/core/cmd.c       | 11 ++++-------
 drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h |  6 ++++++
 2 files changed, 10 insertions(+), 7 deletions(-)
Thanks, applied to mlx5-next.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help