Re: [PATCH net] ipvlan: call dev_change_flags when reset ipvlan mode

From: Hangbin Liu <redacted>
Date: Wed, 20 Jun 2018 11:22:54 +0800

The only case dev_change_flags() return an err is when we change IFF_UP flag.
Since we only set/reset IFF_NOARP, do you think we still need to check the
return value?

It is bad to try and take shortcuts on error handling using assumptions
like that.

If dev_change_flags() is adjusted to return error codes in more
situations, nobody is going to remember to undo your "optimziation"
here.

Please check for errors, thank you.