Re: [PATCH 2/3] net: phy: vitesse: Add support for VSC73xx
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2018-06-14 16:29:38
On 06/14/2018 05:35 AM, Linus Walleij wrote:
The VSC7385, VSC7388, VSC7395 and VSC7398 are integrated switch/router chips for 5+1 or 8-port switches/routers. When managed directly by Linux using DSA we need to do a special set-up "dance" on the PHY. Unfortunately these sequences switches the PHY to undocumented pages named 2a30 and 52b6 and does undocumented things. It is described by these opaque sequences also in the reference manual. This is a best effort to integrate it anyways. Signed-off-by: Linus Walleij <redacted>
Probably as good as it can get given the information you have access to. Maybe the guys at Mircochip could help, adding them. Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Just one nit below:
quoted hunk ↗ jump to hunk
--- drivers/net/phy/vitesse.c | 162 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 162 insertions(+)diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c index d9dd8fbfffc7..526c71ae7d96 100644 --- a/drivers/net/phy/vitesse.c +++ b/drivers/net/phy/vitesse.c@@ -16,6 +16,7 @@ #include <linux/module.h> #include <linux/mii.h> #include <linux/ethtool.h> +#include <linux/delay.h>
Is that needed? -- Florian